i recommend brining an 8lb cut of pork shoulder for 8 hours minimum, and 24 hours absolute maximum. i usually sit somewhere between the two and go for 12 hours, or overnight. if you have a smaller cut of meat than this then less time is fine, but i would still aim to leave it overnight.